Add allow_partial_search_results flag to search requests with default setting true#28440
Add allow_partial_search_results flag to search requests with default setting true#28440markharwood merged 3 commits intoelastic:masterfrom
Conversation
|
Initial commit here just for CI checking that forward-port of 6.x-based #27906 was successful. Once green I'll add a commit that changes the default for |
80a1cdc to
56a2746
Compare
colings86
left a comment
There was a problem hiding this comment.
I left a couple of comments int eh tests.
There was a problem hiding this comment.
Could you explain why this is needed? This test doesn't appear to test partial results?
There was a problem hiding this comment.
That was a necessity from a previously failing trial on 6.x - if I recall correctly it was for searches that rely on the use of field data. Ditto the other test
There was a problem hiding this comment.
Could you explain why this is needed? This test doesn't appear to test partial results?
1f68b79 to
e9606f3
Compare
|
Reverted the code that defaults searches to strict (error on partial results). Will open a separate issue once this is pushed to consider changing the default to strict. |
|
CI build failures look to all be related to BWC checks with the 6.3 snapshot that doesn't yet have the new allowPartialSearchResults flag serializing in SearchRequest |
|
If I can assist in integrating a change like this with cross-cutting BWC implications, please let me know. I am always happy to help. |
|
@jasontedor Thanks for the offer of help. I have 2 PRs lined up ready to push (if I can get an OK on this one, @colings86 ?)
Not sure if there needs to be a gap between 1) and 2) waiting for the 6.x build to make it through the intake tests? After all this is done I'll open a separate issue to open the debate on whether new cluster default setting is to fail on partial results. |
|
@markharwood I think that this would help keep the build green every step of the way and let you integrate this at a leisurely pace:
|
… setting = true. When false, will error if search either timeouts, has partial errors or has missing shards rather than returning partial search results. A cluster-level setting provides a default for searches with no flag. Closes elastic#27435
e9606f3 to
0f34b2a
Compare
When false, will error if search either timeouts, has partial errors or has missing shards rather
than returning partial search results. A cluster-level setting provides a default for searches
with no flag.
Closes #27435